2.0.1 map enhancements #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (13)
- assets/css/scss/_maps.scss (1)
- assets/css/style.css (1)
- assets/css/style.scss (1)
- assets/js/blocks/general.js (2)
- assets/js/blocks/maps.js (1)
- assets/js/src/maps.js (8)
- includes/classes/blocks/class-bindings.php (1)
- includes/classes/blocks/class-registration.php (2)
- includes/classes/legacy/class-frontend.php (4)
- includes/classes/legacy/class-maps.php (10)
- includes/classes/legacy/class-tour-operator.php (1)
- includes/constants/settings-fields.php (2)
- includes/template-tags/maps.php (8)
Files ignored due to filter (69)
- assets/img/Typecalendar-icon.png
- assets/img/Typetours-icon.png
- assets/img/accommodation-type-TO-icon-black-20px.png
- assets/img/accommodation.png
- assets/img/activities.png
- assets/img/best-months-to-travel-TO-icon-black-20px.png
- assets/img/blocks/placeholder-map-1920x656.jpg
- assets/img/dates-travelled-icon-black-20px.png
- assets/img/duration-icon-black-20px.png
- assets/img/from-price-TO-icon-black-20px.png
- assets/img/left-arrow-new.svg
- assets/img/map-TO-icon-black-20px.png
- assets/img/mystery-man-square.png
- assets/img/mystery-man-wide.png
- assets/img/offers.png
- assets/img/placeholders/placeholder-accommodation-1920x600.jpg
- assets/img/placeholders/placeholder-accommodation-350x350.jpg
- assets/img/placeholders/placeholder-accommodation-360x168.jpg
- assets/img/placeholders/placeholder-accommodation-750x350.jpg
- assets/img/placeholders/placeholder-activity-1920x600.jpg
- assets/img/placeholders/placeholder-activity-350x350.jpg
- assets/img/placeholders/placeholder-activity-360x168.jpg
- assets/img/placeholders/placeholder-activity-750x350.jpg
- assets/img/placeholders/placeholder-banner-1920x600.jpg
- assets/img/placeholders/placeholder-destination-1920x600.jpg
- assets/img/placeholders/placeholder-destination-350x350.jpg
- assets/img/placeholders/placeholder-destination-360x168.jpg
- assets/img/placeholders/placeholder-destination-750x350.jpg
- assets/img/placeholders/placeholder-destination-general.jpg
- assets/img/placeholders/placeholder-general-1920x600.jpg
- assets/img/placeholders/placeholder-general-350x350.jpg
- assets/img/placeholders/placeholder-general-360x168.jpg
- assets/img/placeholders/placeholder-general-750x350.jpg
- assets/img/placeholders/placeholder-map-1170x400.jpg
- assets/img/placeholders/placeholder-map-350x350.jpg
- assets/img/placeholders/placeholder-map-400x400.jpg
- assets/img/placeholders/placeholder-page-350x350.jpg
- assets/img/placeholders/placeholder-page-360x168.jpg
- assets/img/placeholders/placeholder-page-750x350.jpg
- assets/img/placeholders/placeholder-page-general.jpg
- assets/img/placeholders/placeholder-post-1920x600.jpg
- assets/img/placeholders/placeholder-post-350x350.jpg
- assets/img/placeholders/placeholder-post-360x168.jpg
- assets/img/placeholders/placeholder-post-750x350.jpg
- assets/img/placeholders/placeholder-review-1920x600.jpg
- assets/img/placeholders/placeholder-review-350x350.jpg
- assets/img/placeholders/placeholder-review-360x168.jpg
- assets/img/placeholders/placeholder-review-750x350.jpg
- assets/img/placeholders/placeholder-special-1920x600.jpg
- assets/img/placeholders/placeholder-special-350x350.jpg
- assets/img/placeholders/placeholder-special-360x168.jpg
- assets/img/placeholders/placeholder-special-750x350.jpg
- assets/img/placeholders/placeholder-team-1920x600.jpg
- assets/img/placeholders/placeholder-team-350x350.jpg
- assets/img/placeholders/placeholder-team-360x168.jpg
- assets/img/placeholders/placeholder-team-750x350.jpg
- assets/img/placeholders/placeholder-tour-1920x600.jpg
- assets/img/placeholders/placeholder-tour-350x350.jpg
- assets/img/placeholders/placeholder-tour-360x168.jpg
- assets/img/placeholders/placeholder-tour-750x350.jpg
- assets/img/placeholders/placeholder-vehicle-1920x600.jpg
- assets/img/placeholders/placeholder-vehicle-350x350.jpg
- assets/img/placeholders/placeholder-vehicle-360x168.jpg
- assets/img/placeholders/placeholder-vehicle-750x350.jpg
- assets/img/placeholders/placeholder-video-1920x600.jpg
- assets/img/placeholders/placeholder-video-350x350.jpg
- assets/img/placeholders/placeholder-video-360x168.jpg
- assets/img/placeholders/placeholder-video-750x350.jpg
- assets/img/restaurants.png
Files not summarized due to errors (13)
- assets/js/blocks/general.js (nothing obtained from openai)
- assets/css/style.css (nothing obtained from openai)
- assets/css/style.scss (nothing obtained from openai)
- assets/js/src/maps.js (nothing obtained from openai)
- includes/classes/legacy/class-maps.php (diff tokens exceeds limit)
- assets/css/scss/_maps.scss (nothing obtained from openai)
- assets/js/blocks/maps.js (nothing obtained from openai)
- includes/classes/blocks/class-bindings.php (nothing obtained from openai)
- includes/classes/legacy/class-frontend.php (nothing obtained from openai)
- includes/classes/blocks/class-registration.php (nothing obtained from openai)
- includes/constants/settings-fields.php (nothing obtained from openai)
- includes/template-tags/maps.php (nothing obtained from openai)
- includes/classes/legacy/class-tour-operator.php (nothing obtained from openai)
Files not reviewed due to errors (13)
- assets/css/scss/_maps.scss (no response)
- assets/css/style.css (no response)
- assets/js/blocks/maps.js (no response)
- assets/css/style.scss (no response)
- assets/js/blocks/general.js (no response)
- assets/js/src/maps.js (no response)
- includes/classes/blocks/class-registration.php (no response)
- includes/classes/legacy/class-frontend.php (no response)
- includes/constants/settings-fields.php (no response)
- includes/classes/legacy/class-maps.php (no response)
- includes/classes/blocks/class-bindings.php (no response)
- includes/classes/legacy/class-tour-operator.php (no response)
- includes/template-tags/maps.php (no response)
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
There was a problem hiding this comment.
Files selected (7)
- assets/js/src/maps.js (9)
- changelog.md (1)
- includes/classes/blocks/class-registration.php (3)
- includes/classes/legacy/class-maps.php (1)
- includes/classes/legacy/class-tour-operator.php (2)
- includes/template-tags/general.php (1)
- includes/template-tags/maps.php (9)
Files not summarized due to errors (7)
- includes/classes/legacy/class-maps.php (diff tokens exceeds limit)
- includes/template-tags/maps.php (diff tokens exceeds limit)
- changelog.md (nothing obtained from openai)
- assets/js/src/maps.js (nothing obtained from openai)
- includes/classes/blocks/class-registration.php (nothing obtained from openai)
- includes/template-tags/general.php (nothing obtained from openai)
- includes/classes/legacy/class-tour-operator.php (nothing obtained from openai)
Files not reviewed due to errors (6)
- assets/js/src/maps.js (no response)
- includes/template-tags/general.php (no response)
- includes/classes/legacy/class-tour-operator.php (no response)
- changelog.md (no response)
- includes/template-tags/maps.php (no response)
- includes/classes/blocks/class-registration.php (no response)
Files skipped from review due to trivial changes (1)
- includes/classes/legacy/class-maps.php (diff too large)
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
There was a problem hiding this comment.
Files selected (1)
- includes/classes/legacy/class-tour-operator.php (2)
Files not summarized due to errors (1)
- includes/classes/legacy/class-tour-operator.php (nothing obtained from openai)
Files not reviewed due to errors (1)
- includes/classes/legacy/class-tour-operator.php (no response)
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
|
I have reviewed the pull request - "2.0.1 map enhancements" for the LSX Tour Operator plugin. This update introduces several improvements and fixes related to map functionalities. Key Enhancements:
|
There was a problem hiding this comment.
Files selected (15)
- assets/css/scss/_maps.scss (1)
- assets/css/style.css (1)
- assets/css/style.scss (1)
- assets/js/blocks/general.js (2)
- assets/js/blocks/maps.js (1)
- assets/js/src/maps.js (9)
- changelog.md (1)
- includes/classes/blocks/class-bindings.php (1)
- includes/classes/blocks/class-registration.php (3)
- includes/classes/legacy/class-frontend.php (4)
- includes/classes/legacy/class-maps.php (1)
- includes/classes/legacy/class-tour-operator.php (2)
- includes/constants/settings-fields.php (2)
- includes/template-tags/general.php (1)
- includes/template-tags/maps.php (9)
Files ignored due to filter (69)
- assets/img/Typecalendar-icon.png
- assets/img/Typetours-icon.png
- assets/img/accommodation-type-TO-icon-black-20px.png
- assets/img/accommodation.png
- assets/img/activities.png
- assets/img/best-months-to-travel-TO-icon-black-20px.png
- assets/img/blocks/placeholder-map-1920x656.jpg
- assets/img/dates-travelled-icon-black-20px.png
- assets/img/duration-icon-black-20px.png
- assets/img/from-price-TO-icon-black-20px.png
- assets/img/left-arrow-new.svg
- assets/img/map-TO-icon-black-20px.png
- assets/img/mystery-man-square.png
- assets/img/mystery-man-wide.png
- assets/img/offers.png
- assets/img/placeholders/placeholder-accommodation-1920x600.jpg
- assets/img/placeholders/placeholder-accommodation-350x350.jpg
- assets/img/placeholders/placeholder-accommodation-360x168.jpg
- assets/img/placeholders/placeholder-accommodation-750x350.jpg
- assets/img/placeholders/placeholder-activity-1920x600.jpg
- assets/img/placeholders/placeholder-activity-350x350.jpg
- assets/img/placeholders/placeholder-activity-360x168.jpg
- assets/img/placeholders/placeholder-activity-750x350.jpg
- assets/img/placeholders/placeholder-banner-1920x600.jpg
- assets/img/placeholders/placeholder-destination-1920x600.jpg
- assets/img/placeholders/placeholder-destination-350x350.jpg
- assets/img/placeholders/placeholder-destination-360x168.jpg
- assets/img/placeholders/placeholder-destination-750x350.jpg
- assets/img/placeholders/placeholder-destination-general.jpg
- assets/img/placeholders/placeholder-general-1920x600.jpg
- assets/img/placeholders/placeholder-general-350x350.jpg
- assets/img/placeholders/placeholder-general-360x168.jpg
- assets/img/placeholders/placeholder-general-750x350.jpg
- assets/img/placeholders/placeholder-map-1170x400.jpg
- assets/img/placeholders/placeholder-map-350x350.jpg
- assets/img/placeholders/placeholder-map-400x400.jpg
- assets/img/placeholders/placeholder-page-350x350.jpg
- assets/img/placeholders/placeholder-page-360x168.jpg
- assets/img/placeholders/placeholder-page-750x350.jpg
- assets/img/placeholders/placeholder-page-general.jpg
- assets/img/placeholders/placeholder-post-1920x600.jpg
- assets/img/placeholders/placeholder-post-350x350.jpg
- assets/img/placeholders/placeholder-post-360x168.jpg
- assets/img/placeholders/placeholder-post-750x350.jpg
- assets/img/placeholders/placeholder-review-1920x600.jpg
- assets/img/placeholders/placeholder-review-350x350.jpg
- assets/img/placeholders/placeholder-review-360x168.jpg
- assets/img/placeholders/placeholder-review-750x350.jpg
- assets/img/placeholders/placeholder-special-1920x600.jpg
- assets/img/placeholders/placeholder-special-350x350.jpg
- assets/img/placeholders/placeholder-special-360x168.jpg
- assets/img/placeholders/placeholder-special-750x350.jpg
- assets/img/placeholders/placeholder-team-1920x600.jpg
- assets/img/placeholders/placeholder-team-350x350.jpg
- assets/img/placeholders/placeholder-team-360x168.jpg
- assets/img/placeholders/placeholder-team-750x350.jpg
- assets/img/placeholders/placeholder-tour-1920x600.jpg
- assets/img/placeholders/placeholder-tour-350x350.jpg
- assets/img/placeholders/placeholder-tour-360x168.jpg
- assets/img/placeholders/placeholder-tour-750x350.jpg
- assets/img/placeholders/placeholder-vehicle-1920x600.jpg
- assets/img/placeholders/placeholder-vehicle-350x350.jpg
- assets/img/placeholders/placeholder-vehicle-360x168.jpg
- assets/img/placeholders/placeholder-vehicle-750x350.jpg
- assets/img/placeholders/placeholder-video-1920x600.jpg
- assets/img/placeholders/placeholder-video-350x350.jpg
- assets/img/placeholders/placeholder-video-360x168.jpg
- assets/img/placeholders/placeholder-video-750x350.jpg
- assets/img/restaurants.png
Files not summarized due to errors (15)
- assets/js/blocks/maps.js (nothing obtained from openai)
- assets/css/scss/_maps.scss (nothing obtained from openai)
- assets/js/blocks/general.js (nothing obtained from openai)
- assets/js/src/maps.js (nothing obtained from openai)
- assets/css/style.css (nothing obtained from openai)
- includes/classes/legacy/class-maps.php (diff tokens exceeds limit)
- assets/css/style.scss (nothing obtained from openai)
- includes/classes/legacy/class-frontend.php (nothing obtained from openai)
- changelog.md (nothing obtained from openai)
- includes/template-tags/maps.php (diff tokens exceeds limit)
- includes/classes/blocks/class-bindings.php (nothing obtained from openai)
- includes/classes/blocks/class-registration.php (nothing obtained from openai)
- includes/classes/legacy/class-tour-operator.php (nothing obtained from openai)
- includes/constants/settings-fields.php (nothing obtained from openai)
- includes/template-tags/general.php (nothing obtained from openai)
Files not reviewed due to errors (14)
- assets/css/scss/_maps.scss (no response)
- assets/css/style.scss (no response)
- assets/css/style.css (no response)
- assets/js/blocks/general.js (no response)
- assets/js/src/maps.js (no response)
- assets/js/blocks/maps.js (no response)
- includes/classes/blocks/class-registration.php (no response)
- includes/classes/blocks/class-bindings.php (no response)
- includes/classes/legacy/class-frontend.php (no response)
- changelog.md (no response)
- includes/classes/legacy/class-tour-operator.php (no response)
- includes/constants/settings-fields.php (no response)
- includes/template-tags/general.php (no response)
- includes/template-tags/maps.php (no response)
Files skipped from review due to trivial changes (1)
- includes/classes/legacy/class-maps.php (diff too large)
Review comments generated (0)
- Review: 0
- LGTM: 0
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Add in a map block which covers the following conditions. I took a look at using a variation of another plugins block, but it proved to tricky.
Additional Changes
Designs
Placeholder Showing before click.
Single Country
Single Region
Destination Archive
Single Accommodation
Single Tour
Map Default Marker being changed.
